gpnf-override-parent-merge-tag-on-submission.php: Added support to rename uploaded files in child entries.
#1035
+9
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malayladu
force-pushed
the
malay/add/78123-force-rename-uploaded-files-in-child-entries
branch
from
7ea0075 to
f85e8b2
Compare
veryspry
reviewed
Mar 18, 2025
gp-nested-forms/gpnf-override-parent-merge-tag-on-submission.php
Outdated
Show resolved
Hide resolved
veryspry
approved these changes
Mar 18, 2025
…rename uploaded files in child entries.
malayladu
force-pushed
the
malay/add/78123-force-rename-uploaded-files-in-child-entries
branch
from
f85e8b2 to
c62ed0b
Compare
WalkthroughThis change adds a conditional branch to the Changes
Sequence Diagram(s)sequenceDiagram
participant Submission as Submission Data
participant ParentMergeTags as GPNF_Override_Parent_Merge_Tags
participant FileRenamer as GP_File_Renamer
participant ChildEntry as Child Entry
Submission->>ParentMergeTags: Submit child entry data
ParentMergeTags->>ParentMergeTags: Check GP File Renamer plugin status and version
alt Plugin active and version >1.0.9
ParentMergeTags->>ChildEntry: Retrieve updated child entry
ParentMergeTags->>FileRenamer: Call rename_uploaded_files(force:true)
else Plugin inactive or version <=1.0.9
ParentMergeTags->>Submission: Continue without renaming
end
Suggested Reviewers
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
gp-nested-forms/gpnf-override-parent-merge-tag-on-submission.php (1)
125-133: Well-implemented support for file renaming when parent form values changeThe implementation correctly addresses the requirement to rename uploaded files in child entries when parent form values change. Good job on including version checking to ensure compatibility with the GP File Renamer plugin, and clearly explaining in the comment why version 1.0.9 specifically is required.
Consider adding a brief explanation of what the "force" parameter does in
rename_uploaded_files()to improve future maintainability. For example:- // Force the renaming of uploaded files if set. + // Force the renaming of uploaded files even if they were previously renamed, ensuring they reflect the updated parent form values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
⛑️ Ticket(s): https://secure.helpscout.net/conversation/2849364535/78123
Related PR: https://github.com/gravitywiz/gp-file-renamer/pull/22
Summary
The customer has a nested form with an Upload field. They are using the
{Parent}merge tag in a field, and then using this in GPFR to name the uploaded file, based on a value in the parent form.However, they want it so if the user changes the value on the parent form before submitting, the uploaded file is renamed.